Skip to content

Add Firebase AI KSP Processor #7523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Add Firebase AI KSP Processor #7523

wants to merge 18 commits into from

Conversation

@davidmotson
Copy link
Collaborator

@davidmotson davidmotson commented Oct 30, 2025 •
edited
Loading

  • Adds the Generable and Guide annotations
  • Adds the KSP processor to turn them into firebase AI schema objects
  • Adds publishing plugin to export maven repo for ADMRS

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Oct 30, 2025

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

@davidmotson davidmotson requested a review from rlazo October 30, 2025 19:34
@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2025 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@davidmotson
Copy link
Collaborator Author

davidmotson commented Oct 30, 2025

/gemini review

gemini-code-assist[bot]
gemini-code-assist bot reviewed Oct 30, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a KSP processor for generating Firebase AI schemas, which is a fantastic addition for improving developer experience with Firebase AI. The implementation is well-structured. I've provided a few suggestions to address some minor bugs in the processor logic, improve the API design of the published artifact, and fix some minor formatting issues. Overall, great work!

davidmotson and others added 4 commits October 30, 2025 12:43
@davidmotson @gemini-code-assist
Update firebase-ai-ksp-processor/src/main/kotlin/com/google/firebase/…
811122b 
…ai/ksp/SchemaSymbolProcessor.kt

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@davidmotson @gemini-code-assist
Update firebase-ai-ksp-processor/src/main/kotlin/com/google/firebase/…
0d5d3f7 
…ai/ksp/SchemaSymbolProcessor.kt

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@davidmotson @gemini-code-assist
Update firebase-ai-ksp-processor/README.md
e7a1ab8 
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@davidmotson @gemini-code-assist
Update firebase-ai-ksp-processor/src/main/kotlin/com/google/firebase/…
54e9466 
…ai/annotations/Generable.kt

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 30, 2025 •
edited
Loading

Size Report 1

Affected Products

  • firebase-ai

    TypeBase (813d02b)Merge (ca4606a)Diff
    aar1.11 MB1.14 MB+33.2 kB (+3.0%)
    apk (aggressive)1.71 MB1.74 MB+24.3 kB (+1.4%)
    apk (release)11.0 MB11.0 MB+37.9 kB (+0.3%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/FIbVDL2kYE.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 30, 2025 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.37% (813d02b) to 50.41% (ca4606a) by +0.04%.

    FilenameBase (813d02b)Merge (ca4606a)Diff
    ChildChangeAccumulator.java83.33%96.67%+13.33%

  • firebase-firestore

    Overall coverage changed from 46.04% (813d02b) to 46.04% (ca4606a) by -0.00%.

    FilenameBase (813d02b)Merge (ca4606a)Diff
    PatchMutation.java100.00%98.39%-1.61%

  • firebase-ml-modeldownloader

    Overall coverage changed from 81.96% (813d02b) to 82.21% (ca4606a) by +0.25%.

    FilenameBase (813d02b)Merge (ca4606a)Diff
    FirebaseModelDownloader.java82.21%84.66%+2.45%

  • firebase-storage

    Overall coverage changed from 84.93% (813d02b) to 85.14% (ca4606a) by +0.21%.

    FilenameBase (813d02b)Merge (ca4606a)Diff
    UploadTask.java81.52%83.17%+1.65%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/KI2RzcyHji.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 30, 2025 •
edited
Loading

Startup Time Report 1

The report is too large (117,070 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/rBH0H8XJdA/index.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 4, 2025

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 4, 2025

The public api surface has changed for the subproject firebase-ai:
error: Attempted to change parameter name from prompt to inputPrompt in method com.google.firebase.ai.Chat.sendMessage [ParameterNameChange]
error: Added class com.google.firebase.ai.type.AutoFunctionDeclaration [AddedClass]
error: Added class com.google.firebase.ai.type.JsonSchema [AddedClass]
error: Removed method com.google.firebase.ai.type.Tool.functionDeclarations(java.util.List<com.google.firebase.ai.type.FunctionDeclaration>) [RemovedMethod]
error: Added method com.google.firebase.ai.type.Tool.functionDeclarations(java.util.List<com.google.firebase.ai.type.FunctionDeclaration>,java.util.List>) [AddedMethod]
error: Removed method com.google.firebase.ai.type.Tool.Companion.functionDeclarations(java.util.List<com.google.firebase.ai.type.FunctionDeclaration>) [RemovedMethod]
error: Added method com.google.firebase.ai.type.Tool.Companion.functionDeclarations(java.util.List<com.google.firebase.ai.type.FunctionDeclaration>,java.util.List>) [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rlazo rlazo Awaiting requested review from rlazo

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@davidmotson @google-oss-bot